Skip to content

[main] Update dependencies from dotnet/razor#31508

Merged
marek-safar merged 2 commits intomainfrom
darc-main-4c1b4595-603a-4dea-9d40-a1565e87ed19
Apr 11, 2023
Merged

[main] Update dependencies from dotnet/razor#31508
marek-safar merged 2 commits intomainfrom
darc-main-4c1b4595-603a-4dea-9d40-a1565e87ed19

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 29, 2023

This pull request updates the following dependencies

From https://github.com/dotnet/razor

  • Subscription: 5ba65a57-3ed4-48c1-1d9c-08dac299ead7
  • Build: 20230328.7
  • Date Produced: March 29, 2023 5:24:53 AM UTC
  • Commit: 3be43f6abbdc8d585f17c168f03b18420aab1062
  • Branch: refs/heads/release/dev17.6

@dotnet-maestro
Update dependencies from https://github.com/dotnet/razor build 202303…
f413eae 
…28.7

Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal , Microsoft.CodeAnalysis.Razor.Tooling.Internal , Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
 From Version 7.0.0-preview.23167.3 -> To Version 7.0.0-preview.23178.7
@ghost ghost added Area-CodeFlow untriaged Request triage from a team member labels Mar 29, 2023
@nagilson
Copy link
Member

nagilson commented Mar 29, 2023

Lots 'O test failures here, may you take a peek my friends @dotnet/razor-tooling ?

@davidwengier
Copy link
Member

davidwengier commented Mar 29, 2023 •
edited
Loading

@dotnet/razor-compiler did you want to have a first look?

@nagilson
Copy link
Member

nagilson commented Mar 29, 2023

Interesting... had no idea what razor-tooling is. but now I know. 😉 Razor.Tooling.Internal being in the list of updates is mildly confusing

@davidwengier
Copy link
Member

davidwengier commented Mar 29, 2023

I admit, I am also confused and surprised by it (such that I edited my comment 😝).

@jjonescz jjonescz force-pushed the darc-main-4c1b4595-603a-4dea-9d40-a1565e87ed19 branch from 4e8cea8 to 08b652f Compare March 30, 2023 10:00
@jjonescz jjonescz requested a review from a team as a code owner March 30, 2023 10:00
@jjonescz
Copy link
Member

jjonescz commented Mar 30, 2023 •
edited
Loading

The error is

  Could not load file or assembly 'Microsoft.AspNetCore.Razor.Utilities.Shared, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.
     at Microsoft.AspNetCore.Razor.Language.DefaultTagHelperDescriptorBuilder.Build()
     at Microsoft.CodeAnalysis.Razor.DefaultTagHelperDescriptorFactory.CreateDescriptor(INamedTypeSymbol type)
     at Microsoft.CodeAnalysis.Razor.DefaultTagHelperDescriptorProvider.Execute(TagHelperDescriptorProviderContext context)
     at Microsoft.CodeAnalysis.Razor.CompilationTagHelperFeature.GetDescriptors()
     at Microsoft.NET.Sdk.Razor.Tool.DiscoverCommand.ExecuteCore(RazorConfiguration configuration, String projectDirectory, String outputFilePath, String[] assemblies) in /_/src/RazorSdk/Tool/DiscoverCommand.cs:line 150
     at Microsoft.NET.Sdk.Razor.Tool.DiscoverCommand.ExecuteCoreAsync() in /_/src/RazorSdk/Tool/DiscoverCommand.cs:line 121
     at Microsoft.NET.Sdk.Razor.Tool.CommandBase.ExecuteAsync() in /_/src/RazorSdk/Tool/CommandBase.cs:line 57
C:\h\w\B9630A53\p\d\sdk\8.0.100-ci\Sdks\Microsoft.NET.Sdk.Razor\targets\Microsoft.NET.Sdk.Razor.CodeGeneration.targets(97,5): error : rzc discover exited with code 1. [C:\h\w\B9630A53\t\dotnetSdkTests\bps5nxle.fnp\Build_WithP2P---6EDBBC83\ClassLibraryMvc21\ClassLibraryMvc21.csproj]

Looks like the way Razor.Utilities.Shared ships changed in dotnet/razor#8331 which might be the reason.

Guessing something like this could fix the problem: dotnet/razor#8542

I also attempted to fix it here by adding Razor.Utilities.Shared as a dependency of the SDK (e065e7b). That fixed the above error, but another error persisted:

CSC : warning CS8785: Generator 'RazorSourceGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Extensions.ObjectPool, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified. [/private/tmp/helix/working/B70E09F5/w/9C3408A3/e/testExecutionDirectory/Build_Compone---8319F3DC/MvcWithComponents.csproj]
  MvcWithComponents -> /private/tmp/helix/working/B70E09F5/w/9C3408A3/e/testExecutionDirectory/Build_Compone---8319F3DC/bin/Debug/net7.0/MvcWithComponents.dll

Microsoft.Extensions.ObjectPool is a dependency of Razor.Utilities.Shared which is a dependency of the source generator. The ObjectPool dependency was added in dotnet/razor#8284 but that version worked. However, changing how Razor.Utilities.Shared ships later in dotnet/razor#8331 might have broken the source generator here.

@jjonescz jjonescz force-pushed the darc-main-4c1b4595-603a-4dea-9d40-a1565e87ed19 branch from 08b652f to f413eae Compare March 30, 2023 12:43
This was referenced Mar 30, 2023
Merged
Merged
@nagilson
Copy link
Member

nagilson commented Apr 7, 2023

@jjonescz Any updates here? Thanks for taking a look

@jjonescz
Copy link
Member

jjonescz commented Apr 7, 2023 •
edited
Loading

Any updates here?

The PR dotnet/razor#8542 in Razor which should fix this has been merged some time ago. I'm not sure when it'll flow here.

@lewing
Copy link
Member

lewing commented Apr 11, 2023 •
edited
Loading

is the razor sdk flowing properly?cc @mmitche

@jjonescz
Copy link
Member

jjonescz commented Apr 11, 2023

Perhaps the bot didn't update since I did a force push on this PR before. So I bumped the versions manually.

@marek-safar marek-safar merged commit 95390b1 into main Apr 11, 2023
@marek-safar marek-safar deleted the darc-main-4c1b4595-603a-4dea-9d40-a1565e87ed19 branch April 11, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marek-safar marek-safar marek-safar approved these changes

Assignees

No one assigned

Labels

Area-CodeFlow untriaged Request triage from a team member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nagilson @davidwengier @jjonescz @lewing @marek-safar